docker: updates Elasticsearch 7.x image to Elastic licensed 7.17.16 #3654
Conversation
Before, we rev-locked our Elasticsearch 7.x image to the last OSS licensed version 7.10.2. This changes to the Elastic licensed current version, 7.17.16, as that's what people would run in production. Note: As this is a test image, not a production image, usage should not violate the Elastic Basic license developers typically use, and is the default. Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
|
|
||
| FROM ghcr.io/openzipkin/java:${java_version} as install | ||
|
|
||
| WORKDIR /install | ||
|
|
||
| # Use latest 7.x version from https://www.elastic.co/downloads/past-releases#elasticsearch | ||
| # Use latest 7.x version from https://www.elastic.co/downloads/past-releases#elasticsearch-no-jdk |
There was a problem hiding this comment.
@xeraa why is there no 8.x here?
There was a problem hiding this comment.
looks like we're to delete the jdk directory, which is fine https://www.elastic.co/guide/en/elasticsearch/reference/current/install-elasticsearch.html#jvm-version
There was a problem hiding this comment.
Yeah, we don't build those any more for 8. It's recommended to stick to the default JDK we provide, but you can delete the shipped JDK folder (optional) and link to any JDK you like (with or without deleting the default JDK)
| LABEL org.opencontainers.image.description="Elasticsearch OSS distribution on OpenJDK and Alpine Linux" | ||
| ARG elasticsearch7_version=7.10.2 | ||
| # Use a full Java distribution rather than adding test modules to the | ||
| # production -jre base layer used by zipkin and zipkin-slim. |
There was a problem hiding this comment.
Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
|
Thanks for the watchful eye @anuraaga! |
|
Looks good. This would be even fine for production (since you don't provide it as a service, don't hack the license, or remove any trademarks) |
Before, we rev-locked our Elasticsearch 7.x image to the last OSS licensed version 7.10.2. This changes to the Elastic licensed current version, 7.17.16, as that's what people would run in production.
Note: As this is a test image, not a production image, usage should not violate the Elastic Basic license developers typically use, and is the default.
cc @openzipkin/elasticsearch and @xeraa