Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli doc: opm serve does not detect DC changes after startup #750

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

joelanford
Copy link
Member

Description of the change:
A CLI documentation change for opm serve

Motivation for the change:
Clarify that opm serve will not reload served content when underlying files in the served directory change.

See operator-framework/olm-docs#177 (comment)

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@timflannagan
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2021
@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #750 (208da74) into master (a4fd56c) will not change coverage.
The diff coverage is n/a.

❗ Current head 208da74 differs from pull request most recent head b8041af. Consider uploading reports for the commit b8041af to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #750   +/-   ##
=======================================
  Coverage   50.24%   50.24%           
=======================================
  Files         101      101           
  Lines        8691     8691           
=======================================
  Hits         4367     4367           
  Misses       3471     3471           
  Partials      853      853           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4fd56c...b8041af. Read the comment docs.

@kevinrizza
Copy link
Member

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelanford, kevinrizza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2021
@openshift-ci openshift-ci bot merged commit 50b78e9 into operator-framework:master Aug 16, 2021
@joelanford joelanford deleted the opm-serve-doc branch August 16, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants