Implement Klipper Upload #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Didn't see #4 when I hacked this together. Since we had a very similar approach, I'd suggest merging it before this one. Then I can refactor this PR to fit the other PR. |
|
I've just added a test in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! I implemented a basic upload for Klipper printers as mentioned in #2.
type, possible values beingBambuandKlipperSince I don't own a Bambu printer, someone would need to test if I didn't break the Bambu upload while refactoring.
I threw the Printer subclasses into the same file for now. Depending on how many printers should be implemented in the future, we should probably move them to their own files.
Open for any feedback of course.
Happy Printing!