Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reducing image size for patched db #2682

Merged
merged 24 commits into from
Aug 18, 2023
Merged

Reducing image size for patched db #2682

merged 24 commits into from
Aug 18, 2023

Conversation

aditya059
Copy link
Member

This PR is to fix issue #1990 (Reduce image size for a patched OracleDB).

@aditya059
Building base image (stage 0) to reuse for patching
89406fd
@aditya059
Fixed issue related to some file not found for patching
3515924
@aditya059
Removed runOracle.sh as file was empty
9f8f6bb
@aditya059
Added support for creating base linux image and creating patched imag…
c97d2ee 
…e directly
@aditya059
Reusing linux base image to reduce container size
d5e6df4
@aditya059
Added podman support and added version flag to help create linux base…
7ba4535 
… accordingly
@aditya059
Updated Readme
1e1bafa
@aditya059
Updated Readme and creating linux base only when -b is provided
073aa01
@aditya059
Fixed Readme
d48274f
@aditya059
Fixed comment
5ff3f81
@aditya059
Building base linux outside loop
822f4d7
@aditya059
Fixed healthcheck command in k8s, patching, 19.3 and 21.3 dockerfiles
9672911
@aditya059
Fixed linux base image build command
5b87c8c
@aditya059
Fixed container tagging command
fb7f49d
@aditya059
Removed HEALTHCHECK_FILE env var
1867554
@aditya059
Fixed healthcheck command in patching dockerfile
4e533b0
@aditya059
Fixed base linux creation command
933a8a6
@aditya059
Added env var from k8s dockerfile to patching dockerfile to fix unhea…
f2e3060 
…lthy container issue
@aditya059 aditya059 requested a review from gvenzl as a code owner August 17, 2023 11:20
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Aug 17, 2023
@aditya059 aditya059 linked an issue Aug 17, 2023 that may be closed by this pull request
Reduce image size for a patched OracleDB #1990
Closed
@yunus-qureshi yunus-qureshi self-requested a review August 17, 2023 11:51
@thelateperseus thelateperseus mentioned this pull request Aug 18, 2023
Closed
yunus-qureshi
yunus-qureshi approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@yunus-qureshi yunus-qureshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@gvenzl gvenzl merged commit 8e59a92 into oracle:main Aug 18, 2023
@aditya059 aditya059 deleted the aditya059/reducing_image_size_for_patched_db branch August 23, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvenzl gvenzl gvenzl approved these changes

@yunus-qureshi yunus-qureshi yunus-qureshi approved these changes

Assignees
No one assigned
Labels
database OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce image size for a patched OracleDB
3 participants
@aditya059 @yunus-qureshi @gvenzl