Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

23.4.0 Free Containerfiles release and related changes #2797

Merged

Conversation

aditya059
Copy link
Member

Replaced 23.3.0 dockerfiles with 23.4.0 and related changes

@aditya059 aditya059 requested a review from gvenzl as a code owner May 8, 2024 10:19
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 8, 2024
Copy link
Member

@gvenzl gvenzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two comments in the readme, rest looks good.

OracleDatabase/SingleInstance/README.md Outdated Show resolved Hide resolved
OracleDatabase/SingleInstance/README.md Outdated Show resolved Hide resolved
OracleDatabase/SingleInstance/README.md Outdated Show resolved Hide resolved
OracleDatabase/SingleInstance/README.md Outdated Show resolved Hide resolved
OracleDatabase/SingleInstance/README.md Outdated Show resolved Hide resolved
OracleDatabase/SingleInstance/README.md Outdated Show resolved Hide resolved
OracleDatabase/SingleInstance/README.md Outdated Show resolved Hide resolved
OracleDatabase/SingleInstance/README.md Outdated Show resolved Hide resolved
OracleDatabase/SingleInstance/README.md Outdated Show resolved Hide resolved
OracleDatabase/SingleInstance/README.md Outdated Show resolved Hide resolved
OracleDatabase/SingleInstance/README.md Outdated Show resolved Hide resolved
Copy link
Member

@Djelibeybi Djelibeybi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RUN directives in Containerfile.free are missing a \ at the end of each line.

@aditya059 aditya059 force-pushed the aditya059/23.4.0_free_dockerfile_release branch 2 times, most recently from 97de3cd to 2d971f2 Compare May 9, 2024 10:05
@aditya059 aditya059 force-pushed the aditya059/23.4.0_free_dockerfile_release branch from 2d971f2 to 768fa7b Compare May 9, 2024 12:06
@gvenzl
Copy link
Member

gvenzl commented May 9, 2024

Hey @aditya059, looks good to me.

Once @yunus-qureshi and @cjbj also approve, I'll merge the request.

@gvenzl gvenzl merged commit e15651e into oracle:main May 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants