-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
23.4.0 Free Containerfiles release and related changes #2797
23.4.0 Free Containerfiles release and related changes #2797
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two comments in the readme, rest looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The RUN
directives in Containerfile.free
are missing a \
at the end of each line.
OracleDatabase/SingleInstance/dockerfiles/23.4.0/Containerfile.free
Outdated
Show resolved
Hide resolved
OracleDatabase/SingleInstance/dockerfiles/23.4.0/Containerfile.free
Outdated
Show resolved
Hide resolved
97de3cd
to
2d971f2
Compare
2d971f2
to
768fa7b
Compare
Hey @aditya059, looks good to me. Once @yunus-qureshi and @cjbj also approve, I'll merge the request. |
Replaced 23.3.0 dockerfiles with 23.4.0 and related changes