-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing metadata for hibernate-core #496
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this kind of hints should be determine dynamically on Framework side and not contributed in a static way here. I implemented that on Spring Framework via spring-projects/spring-framework#32842 and spring-projects/spring-framework#32967, so I propose to decline this PR and close it unmerged.
@christophstrobl Ok for you?
@sdeleuze framework support for this kind of stuff is very nice but will not work for those not relying on them. Since they are hibernate core types I'd rather see them present here. |
@melix Any thoughts? |
@msupic @dstepanov is this needed for Micronaut? |
It would be nice to have it. I don't know what the reasoning is for having it determined dynamically. It might be a good idea for the native config to provide a list of interfaces/abstract classes meant to be instantiated by the reflection. Any implementation class would be automatically added, and all the constructors would be open for reflection. |
The reason for implementing a dynamic discovery is to handle custom implementation specified via annotation, but this PR provide default ones which does not hurt with Spring feature, so let's maybe merge it to provide support for the most common use cases with all frameworks. |
What does this PR do?
Add missing metadata for hibernate-core required to instantiate generator types retrieved from annotation attribute.
Closes: #323
Checklist before merging