Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing metadata for hibernate-core #496

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

christophstrobl
Copy link
Contributor

What does this PR do?

Add missing metadata for hibernate-core required to instantiate generator types retrieved from annotation attribute.
Closes: #323

Checklist before merging

@christophstrobl christophstrobl requested a review from a team as a code owner May 21, 2024 12:43
@christophstrobl christophstrobl requested a review from melix May 21, 2024 12:43
@sdeleuze sdeleuze requested review from sdeleuze and removed request for melix June 6, 2024 12:42
Copy link
Collaborator

@sdeleuze sdeleuze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this kind of hints should be determine dynamically on Framework side and not contributed in a static way here. I implemented that on Spring Framework via spring-projects/spring-framework#32842 and spring-projects/spring-framework#32967, so I propose to decline this PR and close it unmerged.

@christophstrobl Ok for you?

@christophstrobl
Copy link
Contributor Author

@sdeleuze framework support for this kind of stuff is very nice but will not work for those not relying on them. Since they are hibernate core types I'd rather see them present here.

@sdeleuze sdeleuze requested a review from melix June 7, 2024 07:24
@sdeleuze
Copy link
Collaborator

sdeleuze commented Jun 7, 2024

@melix Any thoughts?

@melix
Copy link
Member

melix commented Jun 10, 2024

@msupic @dstepanov is this needed for Micronaut?

@dstepanov
Copy link

It would be nice to have it. I don't know what the reasoning is for having it determined dynamically.

It might be a good idea for the native config to provide a list of interfaces/abstract classes meant to be instantiated by the reflection. Any implementation class would be automatically added, and all the constructors would be open for reflection.

@sdeleuze
Copy link
Collaborator

The reason for implementing a dynamic discovery is to handle custom implementation specified via annotation, but this PR provide default ones which does not hurt with Spring feature, so let's maybe merge it to provide support for the most common use cases with all frameworks.

@melix melix merged commit ea95723 into oracle:master Jul 24, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants