Add missing metadata for kafka client sasl scram mechanism #511
Conversation
…chanism classes added - ScramSaslClient$ScramSaslClientFactory class with allDeclaredConstructors and allDeclaredMethods - ScramLoginModule class with allDeclaredConstructors and allDeclaredMethods Signed-off-by: Simone Pulcini <[email protected]>
Signed-off-by: Simone Pulcini <[email protected]>
…tries missing Signed-off-by: Simone Pulcini <[email protected]>
spulci
changed the title
| @@ -139,6 +139,16 @@ | |||
| } | |||
| ] | |||
| }, | |||
| { | |||
| "name": "org.apache.kafka.common.security.scram.internals.ScramSaslClient$ScramSaslClientFactory", | |||
There was a problem hiding this comment.
Can we have a typeReachable condition here? This will include it for all projects that have kafka on the classpath.
There was a problem hiding this comment.
I'm pushing a couple of typeReachable conditions to both entries I've submitted. Let me know if they are ok or more strict ones are needed (in that case any help is appreciated).
…nfig.json added typeReachable to ScramSaslClient$ScramSaslClientFactory added typeReachable to ScramLoginModule Signed-off-by: Simone Pulcini <[email protected]>
|
Could you please verify the checkboxes. Especially: For all tests where I am not the sole author, I have added a comment that proves I may publish them under the specified license (see the tests section from our contributing document) |
I've checked the box considering the fact that I'm the sole author of the added test method offered in this PR. For the other check, yes I've consider adding the metadata to the Apache repository but I don't know how to make a contribution on their repos. |
Perfect, thank you for responding so quickly.
Thanks, that is OK. Ideally in those cases we should open a ticket on the repo stating that the support is needed. This allows the community to upvote the ticket. |
What does this PR do?
Closes #510
Add missing metadata for Kafka Client SCRAM/SASL mechanism.
Note: This is my first PR in this repo: any help in the code review is greatly appreciated!
Code sections where the PR accesses files, network, docker or some external service
(example link to code section)
Checklist before merging