-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Hibernate 6.6.0.Final
#523
Conversation
Changes: - Metadata from oracle/graalvm-reachability-metadata#523 - Spring Boot 3.4.0-SNAPSHOT - ext['hibernate.version'] = "6.6.0.Final"
Some entries need to be excluded before this PR is merged, will push an update shortly. |
tests/src/org.hibernate.orm/hibernate-core/6.6.0.Final/gradle/wrapper/gradle-wrapper.jar
Outdated
Show resolved
Hide resolved
tests/src/org.hibernate.orm/hibernate-core/6.6.0.Final/gradle/wrapper/gradle-wrapper.properties
Outdated
Show resolved
Hide resolved
tests/src/org.hibernate.orm/hibernate-core/6.6.0.Final/gradlew.bat
Outdated
Show resolved
Hide resolved
Sure, I will wait for your update, but before we merge this PR, can we remove gradle stuff added to this library testing? All other tests are using top level gradle infrastructure |
63ac2cc
to
a0bd31a
Compare
@dnestoro Done, I introduced it as it was needed by As the script seems to generate far more metadata, it chose to just add missing entries for Please wait for @christophstrobl green light before merging it. |
Should we add this one also showed up in the diff comparing metadata to 6.5: {
"condition" : {
"typeReachable" : "org.hibernate.dialect.function.array.AbstractArrayContainsFunction"
},
"name" : "org.hibernate.internal.log.DeprecationLogger_$logger",
"methods" : [ {
"name" : "<init>",
"parameterTypes" : [ "org.jboss.logging.Logger" ]
} ]
} might be covered by which is in place. {
"condition":{"typeReachable":"org.hibernate.internal.log.DeprecationLogger"},
"name":"org.hibernate.internal.log.DeprecationLogger_$logger",
"methods":[{"name":"<init>","parameterTypes":["org.jboss.logging.Logger"] }]
}, |
Add missing reflection entries for [Lorg.hibernate.event.spi.PostUpsertEventListener; and org.hibernate.internal.log.ConnectionInfoLogger_$logger to the Hibernate 6.5.0.Final metadata to create the 6.6.0.Final one.
a0bd31a
to
1400a7f
Compare
@christophstrobl Good point for I think I tested those metadata with Spring Boot @dnestoro The PR looks ready to be merged to me. |
...e-core/6.6.0.Final/src/test/java/org_hibernate_orm/hibernate_core/AbstractHibernateTest.java
Show resolved
Hide resolved
LGTM, but since the PR is huge, please wait for a second review as well. cc @olpaw |
I looked at the dirdiff for |
Please wait before merging it we have understood another issue we see with Spring. Will post an update later.