Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove confusing example in library-and-framework-list-schema.json #527

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

eregon
Copy link
Member

@eregon eregon commented Aug 26, 2024

What does this PR do?

That 2nd details entry in the example was confusing, because if the Native Image config is tracked in this repo vs upstream then that would be tracked in files such as https://github.com/oracle/graalvm-reachability-metadata/blob/master/metadata/io.netty/netty-common/index.json and not in https://github.com/oracle/graalvm-reachability-metadata/blob/master/library-and-framework-list.json which seems to only be when it is in upsteam.

Checklist before merging

@eregon eregon requested a review from a team as a code owner August 26, 2024 15:56
@eregon eregon requested a review from melix August 26, 2024 15:56
@eregon
Copy link
Member Author

eregon commented Aug 26, 2024

@fniephaus Could you review this?

Copy link
Member

@fniephaus fniephaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fniephaus fniephaus merged commit 8f5234a into oracle:master Aug 26, 2024
5 checks passed
@eregon eregon deleted the patch-1 branch August 27, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants