Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable testcontainers tests #546

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

Kehrlann
Copy link
Contributor

@Kehrlann Kehrlann commented Oct 11, 2024

What does this PR do?

Re-enable Testcontainers tests using the latest Ryuk image, v0.10.2, which does not package vulnerabilities - added it to the allow-list in #547

There is one separate commit for each testcontainers version.

Closes #250 .

Code sections where the PR accesses files, network, docker or some external service

Both tests now access Docker; the testcontainers/ryuk:0.10.2 image has been added to the list of required images.

Checklist before merging

Not applicable:

@Kehrlann Kehrlann requested a review from a team as a code owner October 11, 2024 09:18
@Kehrlann Kehrlann requested a review from msupic October 11, 2024 09:18
@Kehrlann Kehrlann changed the title Testcontainers tests ryuk Re-enable testcontainers tests Oct 11, 2024
@Kehrlann Kehrlann force-pushed the testcontainers-tests-ryuk branch from e4ba9bf to a5cca7b Compare October 17, 2024 08:27
@Kehrlann
Copy link
Contributor Author

Updated to ryuk:0.10.2 which does not suffer from the previous patch version's lifecycle issues.

@dnestoro dnestoro merged commit 5fda11b into oracle:master Nov 5, 2024
15 checks passed
@Kehrlann Kehrlann deleted the testcontainers-tests-ryuk branch November 5, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable testcontainers tests once ryuk docker image is replaced with some less vulnerable
2 participants