Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: memo is receiver addr #29

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Conversation

trung2891
Copy link
Member

No description provided.

@trung2891 trung2891 requested a review from ducphamle2 August 8, 2024 07:24
Copy link

github-actions bot commented Aug 8, 2024

badge

Code Coverage Summary

Filename                                         Stmts    Miss  Cover    Missing
---------------------------------------------  -------  ------  -------  -------------------------------------------------------------------------------------------------------------------------------------------------------------------------
contracts/cw-ics20-latest/src/contract.rs          385      76  80.26%   48, 67, 148-164, 218, 286, 330, 335, 362, 384, 470, 476, 515-518, 535-537, 543-544, 551, 587-588, 757-765, 771, 774-775, 778-783, 789, 793-802, 894-934, 961-962, 971-975
contracts/cw-ics20-latest/src/ibc.rs               260      96  63.08%   97-125, 165-166, 171-172, 177, 183-189, 315, 381-388, 399, 439-447, 455-469, 493-494, 513-514, 594-604, 615-718, 755
contracts/cw-ics20-latest/src/ibc_hooks.rs          21      21  0.00%    11-66
contracts/cw-ics20-latest/src/query_helper.rs       28       0  100.00%
contracts/cw-ics20-latest/src/state.rs              37       9  75.68%   134-136, 163-174
packages/cw20-ics20-msg/src/amount.rs               64       7  89.06%   74-78, 91, 110, 147-148
packages/cw20-ics20-msg/src/converter.rs            47      12  74.47%   69-76, 89-94
packages/cw20-ics20-msg/src/helper.rs               23       8  65.22%   31, 38-47
packages/cw20-ics20-msg/src/ibc_hooks.rs            24       6  75.00%   29, 35, 50, 53-55
TOTAL                                              889     235  73.57%

Diff against master

Filename                                      Stmts    Miss  Cover
------------------------------------------  -------  ------  --------
contracts/cw-ics20-latest/src/ibc.rs              0      +4  -1.54%
contracts/cw-ics20-latest/src/ibc_hooks.rs       +1      +1  +100.00%
packages/cw20-ics20-msg/src/amount.rs             0      +2  -3.12%
TOTAL                                            +1      +7  -0.76%

Results for commit: 59eeed2

Minimum allowed coverage is 90%

♻️ This comment has been updated with latest results

Copy link
Collaborator

@ducphamle2 ducphamle2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ducphamle2 ducphamle2 merged commit 060b86f into master Aug 8, 2024
1 of 2 checks passed
@trung2891 trung2891 deleted the fix/memo-is-receiver-addr branch August 8, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants