Feat/permissionless todo #1058
Open
Feat/permissionless todo #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mon in various components
…ports for btcTokens
…hboard link in Sidebar
Deploying beta-oraidex with
|
| Latest commit: |
0dbfc4f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://797484e5.beta-oraidex.pages.dev |
| Branch Preview URL: | https://develop-v3.beta-oraidex.pages.dev |
…ved consistency and usability
…, and update styles in NewTokenModal
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| onChange={(e) => setTokenLogoUrl(e?.target?.value)} | ||
| placeholder="(Optional) https://orai.io" | ||
| /> | ||
| {tokenLogoUrl && <img src={tokenLogoUrl} alt="Logo" width={150} height={150}/>} |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI about 18 hours ago
To fix the problem, we need to ensure that the tokenLogoUrl is properly sanitized before being used in the img tag. This can be done by validating the URL to ensure it is a safe and well-formed URL. We can use a library like validator to perform this validation.
- Install the
validatorlibrary if it is not already installed. - Import the
validatorlibrary in the file. - Use the
isURLmethod from thevalidatorlibrary to check if thetokenLogoUrlis a valid URL before setting it in the state. - Only render the
imgtag if thetokenLogoUrlis a valid URL.
Suggested changeset
2
src/pages/Pools/NewTokenModal/NewTokenModal.tsx
| @@ -21,2 +21,3 @@ | ||
| import { FC, useRef, useState } from 'react'; | ||
| import validator from 'validator'; | ||
| import NumberFormat from 'react-number-format'; | ||
| @@ -325,6 +326,13 @@ | ||
| }} | ||
| onChange={(e) => setTokenLogoUrl(e?.target?.value)} | ||
| onChange={(e) => { | ||
| const url = e?.target?.value; | ||
| if (validator.isURL(url)) { | ||
| setTokenLogoUrl(url); | ||
| } else { | ||
| setTokenLogoUrl(''); | ||
| } | ||
| }} | ||
| placeholder="(Optional) https://orai.io" | ||
| /> | ||
| {tokenLogoUrl && <img src={tokenLogoUrl} alt="Logo" width={150} height={150} />} | ||
| {tokenLogoUrl && validator.isURL(tokenLogoUrl) && <img src={tokenLogoUrl} alt="Logo" width={150} height={150} />} | ||
| </div> |
package.json
Outside changed files
| @@ -84,3 +84,4 @@ | ||
| "vite-tsconfig-paths": "^5.0.1", | ||
| "@ton/crypto": "^3.3.0" | ||
| "@ton/crypto": "^3.3.0", | ||
| "validator": "^13.12.0" | ||
| }, |
This fix introduces these dependencies
| Package | Version | Security advisories |
| validator (npm) | 13.12.0 | None |
Copilot is powered by AI and may make mistakes. Always verify output.
…onality and styling, including search input integration and token logo handling
…n in SelectToken component
…ndling, including allowance management and multiple asset support
…/oraiswap-frontend into feat/permissionless-todo
…kens for token selection and improve icon handling
…oken icon handling in WithdrawLiquidityModal
…inspection logic with address handling and balance retrieval
…token icon handling in modals
…r improved icon management in PoolV3
…ta retrieval for token inspection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.