Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing missing memo case on bridging sol x oraichain #1069

Closed
wants to merge 2 commits into from
Closed

Fixing missing memo case on bridging sol x oraichain #1069

wants to merge 2 commits into from

Conversation

perfogic
Copy link
Member

@perfogic perfogic commented Dec 6, 2024 •
edited
Loading

@perfogic perfogic requested review from haunv3, quangdz1704 and toandq2009 and removed request for quangdz1704 December 6, 2024 03:24
meomeocoj
meomeocoj previously approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@meomeocoj meomeocoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vuonghuuhung
vuonghuuhung previously approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@vuonghuuhung vuonghuuhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍵

@perfogic perfogic dismissed stale reviews from vuonghuuhung and meomeocoj December 6, 2024 03:38

The merge-base changed after approval.

haunv3
haunv3 previously approved these changes Dec 6, 2024
View reviewed changes
@perfogic perfogic dismissed haunv3’s stale review December 6, 2024 03:45

The merge-base changed after approval.

meomeocoj
meomeocoj previously approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@meomeocoj meomeocoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@perfogic perfogic dismissed meomeocoj’s stale review December 6, 2024 03:54

The merge-base changed after approval.

meomeocoj
meomeocoj previously approved these changes Dec 6, 2024
View reviewed changes
haunv3
haunv3 previously approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@haunv3 haunv3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

vuonghuuhung
vuonghuuhung previously approved these changes Dec 6, 2024
View reviewed changes
quangdz1704
quangdz1704 previously approved these changes Dec 6, 2024
View reviewed changes
@perfogic perfogic dismissed stale reviews from quangdz1704, vuonghuuhung, haunv3, and meomeocoj December 6, 2024 03:59

The merge-base changed after approval.

@haunv3 haunv3 closed this Dec 6, 2024
@perfogic perfogic deleted the hot_fix/fix_missing_memo_on_bridge branch December 6, 2024 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haunv3 haunv3 haunv3 approved these changes

@vuonghuuhung vuonghuuhung vuonghuuhung left review comments

@quangdz1704 quangdz1704 quangdz1704 left review comments

@meomeocoj meomeocoj meomeocoj left review comments

@toandq2009 toandq2009 Awaiting requested review from toandq2009

@trungbach trungbach Awaiting requested review from trungbach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@perfogic @haunv3 @meomeocoj @quangdz1704 @vuonghuuhung @ducphamle2