Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: support variable substitution for cf apps #234

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

o-orand
Copy link
Member

@o-orand o-orand commented Jan 18, 2019

TODO:

  • illustrate usage in reference dataset
  • add cf integration tests, related to Use a reference data set to increase test coverage #108
    • enable & load cf-app pipeline
    • generate appropriate docs/reference_dataset/config_repository/hello-world-root-depls/cf-apps-deployments/generic-app/enable-cf-app.yml
      • we can override values in this file
       cf_username: a-test-User
       cf_password: a-test-Password
       cf_organization: my-test-org
       cf_space: my-test-space
      
      • we can retrieve values from credhub (but I'm not sure our concourse has a credhub available)
       #find from /????/main name space
       cf_username: ((coa_cf_username)) 
       cf_password: ((coa_cf_password))
       cf_organization: ((coa_cf_generic_app_org))
       cf_space: ((coa_cf_generic_app_space))
      
    • tag tests requiring a run CF, to be able to skip its when no CF is available

Fixes #188.

Changes proposed in this pull-request:

  • a file ending with vars.yml in application template dir is detected as file with variables to be injected into application manifest.

 - document usage in reference dataset
 - add minimal tests
WIP-tasks(cf_push): support variable substitution for cf apps

a file ending with `vars.yml` in application template dir is detected as
file with `variables` to be injected into application manifest.

fix #188
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrate CF CLI to support variable substitution
1 participant