-
Notifications
You must be signed in to change notification settings - Fork 22
add Table of Contents and update API on README.md #30
Conversation
ca94bb0
to
e782db5
Compare
Also, Edit: Is this used anywhere? seems to be |
7742751
to
1bcc8a1
Compare
I've noticed that the main orbit-db Store API section is incomplete/needs updating as well. As mentioned in orbitdb-archive/orbit-db-docstore#10, perhaps I should move this PR upstream to the orbit-db repo and simply link to the relevant API section from this repo's README.md. Either way, for ease of maintenance, it would be best if one repo references the other. |
2fb5087
to
54275c3
Compare
54275c3
to
aa9e45d
Compare
It'd be really great to get this PR merged as there is a lot of great documentation here that would help many users. @mistakia are you interested to continue and finish this up? Totally fine if not and someone else can take a look. @RichardLitt what do we need to do here from your perspective to be able to merge? |
This looks good to me - I would just work on the params, as adding comments noting it doesn't actually fix the problem. I think @mistakia made a point about what he needs clarified above in this comment. |
Sorry for the delay, just getting back into the swing of things. @haadcode : As @RichardLitt has pointed out, I just need some clarity on the load/replicated events and I should be able to push the rest over the finish line. |
aa9e45d
to
4684573
Compare
@aphelionz Would you be able to help here? |
@mistakia Is this explanation from the orbit-db pinned issues helpful? orbitdb/orbitdb#579 |
ab75f88
to
d218871
Compare
This is ready for review. I updated the docs to make a note that certain arguments are not emitted for
|
c2140da
to
37463bb
Compare
We probably need to update the README a bit now that things like |
Update README with documentation for missing constructor (and options), public methods, and events. In addition, corrects a few event params and uniformly uses
address
to reference the OrbitDB address (instead of inconsistent usage of bothdbname
&address
).Edit: I have removed two
defaultOptions
properties (path
&replicate
) that don't appear to be used. In addition, I have removed theonProgressCallback
param passed toloadFromSnapshot()
that was never used.I've also noticed that a couple events emit inconsistent params.
load
:https://github.com/orbitdb/orbit-db-store/blob/84aa8095c0d08fc428b8c375aa83cb7fe873bc2d/src/Store.js#L207
https://github.com/orbitdb/orbit-db-store/blob/84aa8095c0d08fc428b8c375aa83cb7fe873bc2d/src/Store.js#L313
replicated
:https://github.com/orbitdb/orbit-db-store/blob/84aa8095c0d08fc428b8c375aa83cb7fe873bc2d/src/Store.js#L116
https://github.com/orbitdb/orbit-db-store/blob/84aa8095c0d08fc428b8c375aa83cb7fe873bc2d/src/Store.js#L403
Is this desired? or should I update to have matching params?
TODO
New scripts:
npm run build:docs/tocs
: generates a table of contents for README.mdNew dev dependencies:
markdown-toc
: generates a markdown table of contentsFixes #26