test #22
Open
test #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adda a flag to the csv-merger tool to optionally ignore relatedImages from component operators generated CSV. Signed-off-by: Simone Tiraboschi <[email protected]>
Signed-off-by: orenc1 <[email protected]>
Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
* Apply retry logic in check_defaults.sh Apply retry logic in check_defaults.sh to prevent flakyness due to conflicts by the validating webhook cause by side effects from the previous changes. Signed-off-by: Simone Tiraboschi <[email protected]> * Update Community-Operators Publisher Workflow Since we are now working with floating tags for hco-operator and hco-webhook in the CSV, there is no need to calculate their digests and re-commit to the CSV after building and pushing them. Therefore, upon making a tag with a version, the publish action has been extended to: 1. Build and push the application images (hco-operator, hco-webhook). 2. Calculate and replace the floating tags of the application images with their digests, to be published on community-operators. 3. Build and push the bundle and index image in semver mode (remove 'replaces' field from the CSV). Signed-off-by: orenc1 <[email protected]> * minor unrelated fixes Signed-off-by: orenc1 <[email protected]> Co-authored-by: Simone Tiraboschi <[email protected]>
Signed-off-by: orenc1 <[email protected]>
Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
…rics (kubevirt#1309) - Current alert misses the first increment. The new query fixes that issue. - Current component_name label contains only the name of the operand but it is hard to diagnose. This PR adds object type to label as well. - Now, the operator doesn't update the metric for configmap/kubevirt-storage-class-defaults and configmap/v2v-vmware. This PR fixes that issue as well. Signed-off-by: Erkan Erol <[email protected]>
* Apply retry logic in check_defaults.sh Apply retry logic in check_defaults.sh to prevent flakyness due to conflicts by the validating webhook cause by side effects from the previous changes. Signed-off-by: Simone Tiraboschi <[email protected]> * Update Community-Operators Publisher Workflow Since we are now working with floating tags for hco-operator and hco-webhook in the CSV, there is no need to calculate their digests and re-commit to the CSV after building and pushing them. Therefore, upon making a tag with a version, the publish action has been extended to: 1. Build and push the application images (hco-operator, hco-webhook). 2. Calculate and replace the floating tags of the application images with their digests, to be published on community-operators. 3. Build and push the bundle and index image in semver mode (remove 'replaces' field from the CSV). Signed-off-by: orenc1 <[email protected]> * minor unrelated fixes Signed-off-by: orenc1 <[email protected]> Co-authored-by: Simone Tiraboschi <[email protected]>
* WIP: default permitted devices Signed-off-by: Nahshon Unna-Tsameret <[email protected]> * use go1.15.11 Signed-off-by: Nahshon Unna-Tsameret <[email protected]> * Add the `Disabled` field to the permitted host device objects Add to the check_defaults test Signed-off-by: Nahshon Unna-Tsameret <[email protected]> * Enforce default permitted host devices Signed-off-by: Nahshon Unna-Tsameret <[email protected]> * fix code review comments Signed-off-by: Nahshon Unna-Tsameret <[email protected]> * Change CRD to force unique permitted host devices Remove the permitted host devices validation from the webhook. Instead, change the PciHostDevices' annotation to: "+listType=map" "+listMapKey=pciVendorSelector" And the MediatedDevices' annotation to: "+listType=map" "+listMapKey=mdevNameSelector" Signed-off-by: Nahshon Unna-Tsameret <[email protected]> * rename PciHostDevice.PCIVendorSelector to PciHostDevice.PCIDeviceSelector Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
* Bump KUBEVIRT to v0.41.0-rc.1 Signed-off-by: HCO Bump Bot <[email protected]> * Remove image pinned v0.40.0-nightly... Signed-off-by: Simone Tiraboschi <[email protected]> Co-authored-by: orenc1 <[email protected]> Co-authored-by: Simone Tiraboschi <[email protected]>
* Enable eventual launcher updates by default Add the workloadUpdateStrategy API to the HyperConverged CR. Propagate its fields to KubeVirt Signed-off-by: Nahshon Unna-Tsameret <[email protected]> * add some unit tests to increase coverage Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
Remove descriptions from unstored versions of CRDs to keep the bundle size < 1MiB. Until operator-framework/enhancements#40 got implemented, a bundle should not exceed 1MiB because its internally (in the opm tool) managed with a configmap. Signed-off-by: Simone Tiraboschi <[email protected]>
split writing HyperConverged's status and body (spec/metadata) Since writing to the HyperConverged status must be a seperate write nad we can't write the whole custome resource as an automic operation, it caused several instbility and conflicts. This PR split the right to two calls - if the code modified something in the body (should be with very low frequency, except for during upgrade), HCO will write only the body, and exit with requeue = true to force additional call, then we expect the body not to be modified again, letting HCO to write only the status this time. This is WIP because the unit test can't fully check that in unit tests, as the client mock *does* write the status together with the body, so if there is a mistake here, it will not be found in unit tests, and we need the CI tests to validate. Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
Signed-off-by: HCO Bump Bot <[email protected]> Co-authored-by: kubevirt-bot <[email protected]>
1. refactor tools/docgen/main.go to reduce Cognitive Complexity 2. refactor hack/strip_old_descriptions.py to reduce Cognitive Complexity 3. remove code duplecation from cmd/hyperconverged-cluster-operator/main.go Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
Openshift UI used the spec.version to present the operator version. That feature was removed, so there is no reason for this field anymore. Placing the version in the spec was problematic for two reasons: 1. the user can get the wrong impression that it is possible to upgrade the HCO version by changing its version, because the spec is for the user to edit. 2. we need to sync the spec.version and the status version, but can't do that as an atomic write, but in two different update operation, and that leads to edge cases. Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
Signed-off-by: Zvi Cahana <[email protected]>
Signed-off-by: orenc1 <[email protected]>
Signed-off-by: orenc1 <[email protected]>
Signed-off-by: orenc1 <[email protected]>
Signed-off-by: orenc1 <[email protected]>
|
/rebase |
|
Rebase Bot action has failed. |
Pull Request Test Coverage Report for Build 2350842774
💛 - Coveralls |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: orenc1 [email protected]
Reviewer Checklist
Release note: