Skip to content

Commit

Permalink
Two more order cleanups
Browse files Browse the repository at this point in the history
  • Loading branch information
@cbkerr
cbkerr committed Sep 20, 2023
1 parent 7db35a7 commit 200656e
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions app/src/main/res/layout/list_widget.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,13 @@

<LinearLayout
xmlns:android="http://schemas.android.com/apk/res/android"
android:theme="@style/ListWidgetTheme"
xmlns:app="http://schemas.android.com/apk/res-auto"
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:orientation="vertical"
android:theme="@style/ListWidgetTheme">
android:orientation="vertical">


<LinearLayout
android:id="@+id/list_widget_header_container"
Expand All @@ -20,10 +21,10 @@
<ImageView
android:id="@+id/list_widget_header_logo"
style="@style/BorderlessButton"
android:padding="12dp"
android:layout_width="48dp"
android:layout_height="match_parent"
android:layout_gravity="center_vertical"
android:padding="12dp"
android:src="@drawable/cic_logo_for_widget" />

<LinearLayout
Expand Down

3 comments on commit 200656e

@alphapapa
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbkerr Curious, as someone who isn't very familiar with Android source code, what is the reason for this change? It doesn't seem alphabetical, so does it change the behavior or appearance of the app?

@cbkerr
Copy link
Contributor Author

@cbkerr cbkerr commented on 200656e Oct 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. Android Studio reordered the xml when I was using its visual editor.
I don't believe the order matters, and I wanted the changes to be easier to review, so I tried to put the order back to where it was before.

Because it wasn't in alphabetical order, I thought that there might be a deeper meaning known to original developers.

@alphapapa
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see. Thanks for taking the time to explain that to me. These IDEs with their "code churn"... :)

Please sign in to comment.