Stop notifying data change after every book sync

orgzly · Sep 1, 2022 · 4bb880c · 4bb880c
1 parent a88e502
commit 4bb880c
Showing 1 changed file with 9 additions and 8 deletions.
diff --git a/app/src/main/java/com/orgzly/android/sync/SyncService.kt b/app/src/main/java/com/orgzly/android/sync/SyncService.kt
@@ -324,24 +324,25 @@ class SyncService : Service() {
                                 BookAction.forNow(BookAction.Type.ERROR, e.message ?: ""))
                     }
 
-                    // TODO: Call only if book was loaded, move to usecase
-                    RemindersScheduler.notifyDataSetChanged(App.getAppContext())
-                    ListWidgetProvider.notifyDataSetChanged(App.getAppContext())
-                    SharingShortcutsManager().replaceDynamicShortcuts(App.getAppContext())
-
                     syncStatus.set(SyncStatus.Type.BOOK_ENDED, namesake.name, curr + 1, namesakes.size)
                     announceActiveSyncStatus()
                 }
 
                 curr++
             }
 
-            for (repo in repos) {
-                if (repo is TwoWaySyncRepo) {
-                    repo.tryPushIfHeadDiffersFromRemote()
+            if (!isCancelled) {
+                for (repo in repos) {
+                    if (repo is TwoWaySyncRepo) {
+                        repo.tryPushIfHeadDiffersFromRemote()
+                    }
                 }
             }
 
+            RemindersScheduler.notifyDataSetChanged(App.getAppContext())
+            ListWidgetProvider.notifyDataSetChanged(App.getAppContext())
+            SharingShortcutsManager().replaceDynamicShortcuts(App.getAppContext())
+
             syncStatus.set(SyncStatus.Type.FINISHED, null, 0, 0)
             announceActiveSyncStatus()