Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per book encryption of notebooks #855

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

heinzelotto
Copy link

Hi,

in #687 @nevenz suggested per-book encryption. I had already hacked this together a long time ago and now I want to share it. Please try it out to see whether this is a good approach to build the full feature on.

Features:

  • Global setting to set the default passphrase that can then be easily used for each individual notebook. This passphrase is also tried when downloading existing remote notebooks.
  • Longtap a notebook and "Set Encryption" allows to set the passphrase for an individual notebook. When switching from unencrypted->encrypted there is then also the option to delete the existing unencrypted remote notebook. This is important because I currently reject the case where there are both "book.org" and "book.org.gpg" remote books present
  • Database has been extended to store the encryption status for each notebook. TODO: database migration, I'm lacking experience here
  • I added some cases for the sync & conflict logic, but this needs to be inspected much more rigorously. Test cases are needed here.

@lifebarier
Copy link

Is this effort dead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants