Android R+: request MANAGE_EXTERNAL_STORAGE when creating new git repos #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anything holding this back from being merged? |
|
It's a bit of a hack, and only handles new git repos. Ideally we'd do the same thing for local files and on sync/upgrade. But as I said it seems to work for me 🤷 |
dwoffinden
force-pushed
the
manager
branch
3 times, most recently
from
bcad76c to
3d24ea0
Compare
dwoffinden
force-pushed
the
manager
branch
2 times, most recently
from
c346384 to
8841c8e
Compare
dwoffinden
force-pushed
the
manager
branch
3 times, most recently
from
818173a to
7970455
Compare
dwoffinden
force-pushed
the
manager
branch
2 times, most recently
from
b27a5df to
f2e8233
Compare
|
@nevenz Please note that Git syncing is completely broken until this has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this also needs requesting on sync or upgrade, in case the app/OS is updated or the permission revoked, but as that's more async I'm not sure where to do it. Just adding the manifest entry makes it possible to manually grant it for now in that case.
An alternative would be to use only app-specific directories permitted under scoped storage, or to perhaps use newer file access APIs to have the user grant fine-grained access? But those'd be larger refactors and this unblocks it for now.
This is a rebase of #910, see also #24 (comment)