Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cmake version used for the Frontier build script #4400

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

anagainaru
Copy link
Contributor

Version 3.23.2 is no longer available on Frontier

I prefer spelling out the version (since we can guarantee that this combination will build succesfully), but I am also fine leaving the default versions if this is the preference (in which case we don't need a PR every time a version is no longer supported but users might get some unexpected errors).

@eisenhauer
Copy link
Member

Hmm. I kind of like the idea that we use the latest version and see/fix failures quickly when the version changes. So I'd probably vote for using the default.

@anagainaru
Copy link
Contributor Author

Hmm. I kind of like the idea that we use the latest version and see/fix failures quickly when the version changes. So I'd probably vote for using the default.

Ok, I set the default versions for all the scripts. Before we merge this, I want to check that we can build on all systems. I'll start with Frontier/Perlmutter but I am not sure if I still have access to Polaris/Summit. If I can't find anyone to test on those systems (assuming I don't have access) I'll remove the scripts.

@vicentebolea vicentebolea removed their request for review November 15, 2024 21:11
eisenhauer
eisenhauer previously approved these changes Nov 17, 2024
@anagainaru
Copy link
Contributor Author

Frontier/Perlmutter are building adios2 with Kokkos/CUDA correctly with the new modules. Summit is decommissioned so I removed the scripts.

I could not check Polaris, my account expired. I asked for a renewal, I'll reopen a PR if needed when I get the opportunity to check. This is ready for review.

@anagainaru anagainaru merged commit 4845276 into ornladios:master Nov 20, 2024
38 checks passed
@anagainaru anagainaru deleted the cmake-version branch November 20, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants