Add Endpoint and Protocol required fields to write datastore APIs

orobix · May 9, 2022 · e8ee22a · e8ee22a
1 parent 0201ec2
commit e8ee22a
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/workspace/converters.go b/workspace/converters.go
@@ -136,6 +136,8 @@ func toWriteDatastoreSchema(datastore *Datastore) *SchemaWrapper {
 				StorageAccountName:   datastore.StorageAccountName,
 				StorageContainerName: datastore.StorageContainerName,
 				Credentials:          credentials,
+				Endpoint:             "core.windows.net",
+				Protocol:             "https",
 			},
 		},
 	}

diff --git a/workspace/convertes_test.go b/workspace/convertes_test.go
@@ -94,7 +94,11 @@ func TestToWriteDatastoreSchemaEmptyDatastore(t *testing.T) {
 	a := assert.New(t)
 	datastore := Datastore{}
 	writeSchema := toWriteDatastoreSchema(&datastore)
-	a.Equal(&SchemaWrapper{WriteDatastoreSchemaProperties{Contents: WriteDatastoreSchema{}}}, writeSchema)
+	expected := WriteDatastoreSchemaProperties{Contents: WriteDatastoreSchema{
+		Protocol: "https",
+		Endpoint: "core.windows.net",
+	}}
+	a.Equal(&SchemaWrapper{expected}, writeSchema)
 }
 
 func TestToWriteDatastoreSchema(t *testing.T) {
@@ -122,6 +126,8 @@ func TestToWriteDatastoreSchema(t *testing.T) {
 					TenantId:    datastore.Auth.TenantId,
 					SqlUserName: datastore.Auth.SqlUserName,
 				},
+				Protocol: "https",
+				Endpoint: "core.windows.net",
 			},
 		},
 	}
@@ -151,6 +157,8 @@ func TestToWriteDatastoreSchema_NilAuth(t *testing.T) {
 				StorageAccountName:   datastore.StorageAccountName,
 				StorageContainerName: datastore.StorageContainerName,
 				Credentials:          nil,
+				Endpoint:             "core.windows.net",
+				Protocol:             "https",
 			},
 		},
 	}

diff --git a/workspace/schemas.go b/workspace/schemas.go
@@ -20,6 +20,8 @@ type WriteDatastoreSchema struct {
 	StorageAccountName   string                           `json:"accountName,omitempty"`
 	StorageContainerName string                           `json:"containerName,omitempty"`
 	Credentials          *WriteDatastoreCredentialsSchema `json:"credentials,omitempty"`
+	Endpoint             string                           `json:"endpoint"`
+	Protocol             string                           `json:"protocol"`
 }
 
 type WriteDatastoreSchemaProperties struct {