161 make clear why save-update-submit buttons are disabled #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ine if it should be enabled and set an appropraite, but generic, tooltip
…re of the forms, work in progress
…e it was at the top
|
This improves the tool-tip feedback. From a UX point-of-view we will probably need to make the "Add" and "Save" buttons consistent throughout; have the same position, alignment, styling, and potentially size (depends on context). We may also want to have Add and Save buttons that are sticky or appear both at the top and bottom of tables/forms depending on the amount of content e.g., number of proposals, we have to display. In terms of this PR, changes look okay, breaks nothing and improves tool-tip feedback. |
AllanEngland
deleted the
161-make-clear-why-saveupdatesubmit-buttons-are-disabled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a new button for some forms that automatically changes its tool tip and enable/disable state depending on if the form is dirty and or valid.
I've used this to harmonise some of the forms, they're not all laid out the same yet, but this goes quite some way to improve on what we had.
This pull request contains a lot of changes, they're mostly minor, but any feedback will be appreciated!