Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow to prevent deletion or removal of last PI #285

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

Republicof1
Copy link
Contributor

A refined workflow of modals to support management of investigators on proposal

A refined workflow of modals to support management of investigators on proposal
@AllanEngland
Copy link
Contributor

Looks good to me, but you'll want to fix the (minor) build issues before merging:

Error: src/ProposalEditorView/investigators/List.tsx(1,10): error TS6133: 'Children' is declared but its value is never read.
Error: src/ProposalEditorView/investigators/List.tsx(24,1): error TS6133: 'forEach' is declared but its value is never read.

@DJWalker42
Copy link
Contributor

This is personal opinion but I prefer simply disabling a button when you want to prevent someone from doing something, and providing an alternate tooltip to explain why the button is disabled. Having the button enabled then popping up an alert when it is pressed and the "prevention" condition is met, may feel jarring for the user; "if you knew I couldn't do that why was the button enabled?".

That being said, this does do what it says on the tin. Also, as Allan wrote, those build issues need fixing (very minor i.e., remove the unused imports ).

@Republicof1 Republicof1 merged commit 74488a0 into master Dec 9, 2024
1 check passed
@DJWalker42 DJWalker42 deleted the 264-InvestigatorManagement branch December 11, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants