Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dutch locales #141

Merged
merged 2 commits into from
Sep 13, 2023
Merged

feat: dutch locales #141

merged 2 commits into from
Sep 13, 2023

Conversation

vinckr
Copy link
Member

@vinckr vinckr commented Sep 13, 2023

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@vinckr vinckr requested a review from Benehiko September 13, 2023 10:03
@vinckr vinckr self-assigned this Sep 13, 2023
Copy link
Contributor

@Benehiko Benehiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JSON is incorrect on line 131 and needs a comma.
The variables in the text { variable } should not be translated. they are used to inject values into from Kratos.

src/locales/nl.json Outdated Show resolved Hide resolved
src/locales/nl.json Outdated Show resolved Hide resolved
src/locales/nl.json Outdated Show resolved Hide resolved
src/locales/nl.json Outdated Show resolved Hide resolved
src/locales/nl.json Outdated Show resolved Hide resolved
src/locales/nl.json Outdated Show resolved Hide resolved
src/locales/nl.json Outdated Show resolved Hide resolved
src/locales/nl.json Outdated Show resolved Hide resolved
src/locales/nl.json Outdated Show resolved Hide resolved
@Benehiko
Copy link
Contributor

Benehiko commented Sep 13, 2023

I've fixed it up and it should be alright to merge

@vinckr
Copy link
Member Author

vinckr commented Sep 13, 2023

Thanks Alano!

@vinckr vinckr merged commit b0affee into main Sep 13, 2023
6 checks passed
@Benehiko Benehiko deleted the add-dutch branch September 13, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants