feat: hide label on hidden input type #149
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue or Design Document
Hide the label if the input field is of a hidden type.
In Ory Kratos one-time code flow we have access to the input fields after the initial submit (step 2 of 3). Kratos will send back the nodes as hidden fields which will still have their labels attached.
Related to this PR ory/kratos#3516
Also fixes the resend button. The
auth-code-section
component did not render the hidden input field to specify the method when submitting theresend
button. This is now fixed and the test assertions fixed.Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
Further comments