Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hide label on hidden input type #149

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Conversation

Benehiko
Copy link
Contributor

@Benehiko Benehiko commented Sep 25, 2023

Related Issue or Design Document

Hide the label if the input field is of a hidden type.

In Ory Kratos one-time code flow we have access to the input fields after the initial submit (step 2 of 3). Kratos will send back the nodes as hidden fields which will still have their labels attached.

Related to this PR ory/kratos#3516

Also fixes the resend button. The auth-code-section component did not render the hidden input field to specify the method when submitting the resend button. This is now fixed and the test assertions fixed.

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@Benehiko Benehiko marked this pull request as ready for review September 25, 2023 16:00
@Benehiko Benehiko self-assigned this Sep 26, 2023
@mszekiel mszekiel merged commit 19ef0a9 into main Sep 26, 2023
6 checks passed
@mszekiel mszekiel deleted the fix-hidden-input-label branch September 26, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants