Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add polish locales #168

Merged
merged 7 commits into from
Nov 3, 2023
Merged

feat: add polish locales #168

merged 7 commits into from
Nov 3, 2023

Conversation

veteran29
Copy link
Contributor

@veteran29 veteran29 commented Oct 26, 2023

Related Issue or Design Document

  • none

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@CLAassistant
Copy link

CLAassistant commented Oct 26, 2023

CLA assistant check
All committers have signed the CLA.

@vinckr vinckr requested a review from Demonsthere November 2, 2023 07:56
Copy link
Contributor

@Demonsthere Demonsthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding some suggestions :)

src/locales/pl.json Outdated Show resolved Hide resolved
src/locales/pl.json Outdated Show resolved Hide resolved
src/locales/pl.json Outdated Show resolved Hide resolved
src/locales/pl.json Outdated Show resolved Hide resolved
src/locales/pl.json Outdated Show resolved Hide resolved
src/locales/pl.json Outdated Show resolved Hide resolved
src/locales/pl.json Outdated Show resolved Hide resolved
src/locales/pl.json Outdated Show resolved Hide resolved
src/locales/pl.json Outdated Show resolved Hide resolved
src/locales/pl.json Outdated Show resolved Hide resolved
Co-authored-by: Jakub Błaszczyk <[email protected]>
@veteran29
Copy link
Contributor Author

Applied, thanks. Should've done them after bit more of sleep. 🥴

src/locales/pl.json Outdated Show resolved Hide resolved
Copy link
Contributor

@Demonsthere Demonsthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@Benehiko Benehiko merged commit 87f0f24 into ory:main Nov 3, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants