Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: elements improvements #199

Closed
wants to merge 10 commits into from

Conversation

mszekiel
Copy link
Collaborator

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@mszekiel mszekiel changed the base branch from main to jonas-jonas/elementsv1 August 28, 2024 12:03
@mszekiel mszekiel self-assigned this Sep 2, 2024
@mszekiel mszekiel added enhancement New feature or request and removed enhancement New feature or request labels Sep 2, 2024
@mszekiel mszekiel force-pushed the feat/elements-improvements branch from b7fa894 to 48c9679 Compare September 2, 2024 13:43
@mszekiel mszekiel marked this pull request as ready for review September 2, 2024 15:05
@mszekiel mszekiel requested a review from jonas-jonas September 2, 2024 15:05
@mszekiel mszekiel force-pushed the feat/elements-improvements branch from c033e63 to 0f8a15c Compare September 3, 2024 14:56
@mszekiel mszekiel force-pushed the feat/elements-improvements branch from 3c3a6d7 to b705de6 Compare September 4, 2024 08:57
@jonas-jonas
Copy link
Member

I've moved the non-two step card changes to the base branch manually, and added the two-step card changes in #211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants