Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: improve component naming #218

Merged

Conversation

jonas-jonas
Copy link
Member

@jonas-jonas jonas-jonas commented Sep 27, 2024

TODO:

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@jonas-jonas jonas-jonas self-assigned this Sep 27, 2024
@mszekiel mszekiel force-pushed the jonas-jonas/apiExtractorElementsv1 branch from 601d8c3 to edae683 Compare September 30, 2024 12:09
@jonas-jonas jonas-jonas force-pushed the jonas-jonas/apiExtractorElementsv1 branch 3 times, most recently from fa27259 to 9d90d42 Compare October 9, 2024 11:37
@jonas-jonas jonas-jonas force-pushed the jonas-jonas/apiExtractorElementsv1 branch 3 times, most recently from 3637dac to 37f30d4 Compare October 10, 2024 18:24
@jonas-jonas jonas-jonas marked this pull request as ready for review October 11, 2024 11:13
Copy link
Collaborator

@mszekiel mszekiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like these changes, it's a green 🟢 light from my side.

packages/elements-react/src/components/form/form.tsx Outdated Show resolved Hide resolved
packages/elements-react/src/components/form/form.tsx Outdated Show resolved Hide resolved
@jonas-jonas jonas-jonas force-pushed the jonas-jonas/apiExtractorElementsv1 branch 4 times, most recently from 3226f15 to a33c6c3 Compare October 14, 2024 10:51
@jonas-jonas jonas-jonas force-pushed the jonas-jonas/apiExtractorElementsv1 branch from a33c6c3 to 5f59ccf Compare October 14, 2024 10:54
@jonas-jonas jonas-jonas merged commit 2d56b78 into jonas-jonas/elementsv1 Oct 14, 2024
3 checks passed
@jonas-jonas jonas-jonas deleted the jonas-jonas/apiExtractorElementsv1 branch October 14, 2024 13:16
jonas-jonas added a commit that referenced this pull request Oct 16, 2024
jonas-jonas added a commit that referenced this pull request Oct 16, 2024
jonas-jonas added a commit that referenced this pull request Oct 16, 2024
jonas-jonas added a commit that referenced this pull request Oct 16, 2024
jonas-jonas added a commit that referenced this pull request Oct 16, 2024
jonas-jonas added a commit that referenced this pull request Oct 16, 2024
jonas-jonas added a commit that referenced this pull request Oct 16, 2024
jonas-jonas added a commit that referenced this pull request Oct 16, 2024
jonas-jonas added a commit that referenced this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants