-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: improve component naming #218
Merged
jonas-jonas
merged 1 commit into
jonas-jonas/elementsv1
from
jonas-jonas/apiExtractorElementsv1
Oct 14, 2024
Merged
fix!: improve component naming #218
jonas-jonas
merged 1 commit into
jonas-jonas/elementsv1
from
jonas-jonas/apiExtractorElementsv1
Oct 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszekiel
force-pushed
the
jonas-jonas/apiExtractorElementsv1
branch
from
September 30, 2024 12:09
601d8c3
to
edae683
Compare
jonas-jonas
force-pushed
the
jonas-jonas/apiExtractorElementsv1
branch
3 times, most recently
from
October 9, 2024 11:37
fa27259
to
9d90d42
Compare
jonas-jonas
commented
Oct 9, 2024
jonas-jonas
force-pushed
the
jonas-jonas/apiExtractorElementsv1
branch
3 times, most recently
from
October 10, 2024 18:24
3637dac
to
37f30d4
Compare
mszekiel
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like these changes, it's a green 🟢 light from my side.
packages/elements-react/src/theme/default/components/form/image.tsx
Outdated
Show resolved
Hide resolved
jonas-jonas
force-pushed
the
jonas-jonas/apiExtractorElementsv1
branch
4 times, most recently
from
October 14, 2024 10:51
3226f15
to
a33c6c3
Compare
jonas-jonas
force-pushed
the
jonas-jonas/apiExtractorElementsv1
branch
from
October 14, 2024 10:54
a33c6c3
to
5f59ccf
Compare
aeneasr
approved these changes
Oct 14, 2024
jonas-jonas
added a commit
that referenced
this pull request
Oct 16, 2024
jonas-jonas
added a commit
that referenced
this pull request
Oct 16, 2024
jonas-jonas
added a commit
that referenced
this pull request
Oct 16, 2024
jonas-jonas
added a commit
that referenced
this pull request
Oct 16, 2024
jonas-jonas
added a commit
that referenced
this pull request
Oct 16, 2024
jonas-jonas
added a commit
that referenced
this pull request
Oct 16, 2024
jonas-jonas
added a commit
that referenced
this pull request
Oct 16, 2024
jonas-jonas
added a commit
that referenced
this pull request
Oct 16, 2024
jonas-jonas
added a commit
that referenced
this pull request
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Related Issue or Design Document
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
Further comments