Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace translation merge with custom function #264

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

jonas-jonas
Copy link
Member

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@jonas-jonas jonas-jonas self-assigned this Nov 5, 2024
@jonas-jonas jonas-jonas force-pushed the jonas-jonas/translationMerge branch from 84915a3 to 7631f9e Compare November 5, 2024 16:57
@jonas-jonas jonas-jonas force-pushed the jonas-jonas/translationMerge branch from 7631f9e to 62b66c5 Compare November 5, 2024 16:58
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.92%. Comparing base (05cfcc4) to head (62b66c5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #264      +/-   ##
==========================================
+ Coverage   57.77%   57.92%   +0.15%     
==========================================
  Files          65       65              
  Lines         817      820       +3     
  Branches      100      101       +1     
==========================================
+ Hits          472      475       +3     
  Misses        340      340              
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonas-jonas jonas-jonas merged commit b28bffa into main Nov 5, 2024
13 checks passed
@jonas-jonas jonas-jonas deleted the jonas-jonas/translationMerge branch November 5, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant