Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Chinese translation #278

Merged
merged 5 commits into from
Nov 18, 2024
Merged

feat: add Chinese translation #278

merged 5 commits into from
Nov 18, 2024

Conversation

GWnbsp
Copy link
Contributor

@GWnbsp GWnbsp commented Nov 14, 2024

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@GWnbsp GWnbsp changed the title feat: Add Chinese localization support feat: add Chinese translation Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.92%. Comparing base (32fbd11) to head (de69f29).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #278   +/-   ##
=======================================
  Coverage   57.92%   57.92%           
=======================================
  Files          65       65           
  Lines         820      820           
  Branches      101      101           
=======================================
  Hits          475      475           
  Misses        340      340           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GWnbsp GWnbsp mentioned this pull request Nov 14, 2024
5 tasks
Copy link
Member

@jonas-jonas jonas-jonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT, this looks good.

Thank you for your contribution!

@jonas-jonas jonas-jonas merged commit 33ad3ce into ory:main Nov 18, 2024
6 checks passed
@GWnbsp
Copy link
Contributor Author

GWnbsp commented Nov 21, 2024

#277 issues/277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants