Skip to content

Commit

Permalink
nvme/rc: don't print the nvme connect msg
Browse files Browse the repository at this point in the history
With commit [1], the nvme connect command will show the connect msg
which breaks blktests nvme/ related cases[2], fix it from blktests
side.

[1]
linux-nvme/nvme-cli@0b8d1e0
[2]
$ ./check nvme/003
nvme/003 (test if we're sending keep-alives to a discovery controller) [failed]
    runtime  11.344s  ...  11.346s
    --- tests/nvme/003.out	2024-01-10 04:03:21.975035862 +0100
    +++ /root/blktests/results/nodev/nvme/003.out.bad	2024-01-10 07:19:46.978193215 +0100
    @@ -1,3 +1,4 @@
     Running nvme/003
    +connecting to device: nvme0
     disconnected 1 controller(s)
     Test complete

Signed-off-by: Yi Zhang <[email protected]>
  • Loading branch information
yizhanglinux committed Jan 10, 2024
1 parent a20c4de commit 08b3c63
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tests/nvme/rc
Original file line number Diff line number Diff line change
Expand Up @@ -576,7 +576,7 @@ _nvme_connect_subsys() {
ARGS+=(--ctrl-loss-tmo="${ctrl_loss_tmo}")
fi

nvme connect "${ARGS[@]}" 2> /dev/null
nvme connect "${ARGS[@]}" &> /dev/null

# Wait until device file and uuid/wwid sysfs attributes get ready for
# all namespaces.
Expand Down

0 comments on commit 08b3c63

Please sign in to comment.