-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for ANA support #114
Conversation
I tried to run tests with the changes on kernel version 6.2, and found that number of nvme test cases fail. For example, nvme/004 fail after the commit "nvme: enable ANA support".
|
As for the commit message of the second patch, it would be helpful to note that ANA is the acronym of Asymmetric Namespace Access that NVMe spec 1.4 introduced. (If I'm wrong, please correct me) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hreinecke Thanks for the work. I reviewed and did test run, then made some feedbacks.
One more nit comment: the first three patches have various commit title prefixes "nvme", "nvme/rc" or "test/nvme". but they all modify test/nvme/rc file. The past commits do not have consistent prefix, but I think "nvme/rc" is the good choice.
The 'loop' transport allows for several distinct ports if the transport address is set to a number. Signed-off-by: Hannes Reinecke <[email protected]>
Update functions to support ANA (Asymmetric Namespace Access). Signed-off-by: Hannes Reinecke <[email protected]>
When creating more than one port we need to ensure that the transport address differs, otherwise we cannot connect to it. So automatically increment the transport address (for loop) or the trsvcid (for tcp) to create distinct transport addresses. Signed-off-by: Hannes Reinecke <[email protected]>
Create two ports on the subsystem and connect to both of them, then run a fio job in the background and switch the ANA state of these ports to check that I/O runs during state changes. Signed-off-by: Hannes Reinecke <[email protected]>
@hreinecke Thanks for reworking the patches. Today, I ran the test case nvme/047 and observed it fails.
It looks that the sysfs attribute file ana_grpid is not found under /sys/class/nvme/nvmeX/nvmeXn1. I wonder what I'm missing to make the test case pass. I use kernel v6.2 and nvme-cli v2.2.1. Do I need any changes on top of these? One nit comment is shellcheck warning. The change below for the last patch will avoid it.
|
And we can now retire this in favour of #146 |
This small patchset adds a test for ANA support.
In doing so I also had to update the loop transport to enable more than one port.
But with that the issues mentioned in #113 are gone.