block/033 fix #138
block/033 fix #138
Conversation
tests/block/033
Outdated
| @@ -7,7 +7,7 @@ | |||
| # can be covered | |||
|
|
|||
| . tests/block/rc | |||
| . common/ublk | |||
| . tests/ublk/rc | |||
There was a problem hiding this comment.
This creates dependency from tests/block to tests/ublk, which is not good. Instead, I suggest to take two actions:
- move the UBLK_PROG declarations below from tests/ublk/rc to common/ublk
if which rublk > /dev/null 2>&1; then
export UBLK_PROG="src/rublk_wrapper.sh"
else
export UBLK_PROG="src/miniublk"
fi
- Replace ublk_prog in tests/block/033 with UBLK_PROG.
There was a problem hiding this comment.
Thanks, updated as suggested, will open another PR for the misc fix.
There was a problem hiding this comment.
@ming1 Please help review this change, thanks.
|
Hi @yizhanglinux , thanks for this PR. |
UBLK_PROG was not defined when calling _have_ublk, move the defination
to common/ublk.
Replace ublk_prog with UBLK_PROG in block/033.
common/fio already included in common/rc, so remove the dup inclusion.
$ ./check block/033
block/033 (add & delete ublk device and test if gendisk is leaked) [not run]
driver ublk_drv is not available
is not available
Signed-off-by: Yi Zhang <[email protected]>
yizhanglinux
force-pushed
the
dev-240426-ublk-fix
branch
from
00eb843
to
3618665
Compare
|
@yizhanglinux Thanks! This PR has got merged. FYI, I made a follow-up commit for additional fixes. |
No description provided.