support s390x

[cgwalters]

Copying the bits from here containers/bootc#569 related to bib

It'd also be really great here to figure out how to share code w/Anaconda I'd say.

[achilleas-k]

What code would we share with Anaconda for this?
Are we planning on building ISOs for s390x?

[yoheiueda]

@cgwalters I raised a PR osbuild/images#758 for this issue.

We can add a partition table for s390x after the PR gets merged.

bootc-image-builder/bib/cmd/bootc-image-builder/partition_tables.go

Lines 24 to 121 in 61863ff

	var partitionTables = distro.BasePartitionTableMap{
	arch.ARCH_X86_64.String(): disk.PartitionTable{
	UUID: "D209C89E-EA5E-4FBD-B161-B461CCE297E0",
	Type: "gpt",
	Partitions: []disk.Partition{
	{
	Size: 1 * MebiByte,
	Bootable: true,
	Type: disk.BIOSBootPartitionGUID,
	UUID: disk.BIOSBootPartitionUUID,
	},
	{
	Size: 501 * MebiByte,
	Type: disk.EFISystemPartitionGUID,
	UUID: disk.EFISystemPartitionUUID,
	Payload: &disk.Filesystem{
	Type: "vfat",
	UUID: disk.EFIFilesystemUUID,
	Mountpoint: "/boot/efi",
	Label: "EFI-SYSTEM",
	FSTabOptions: "umask=0077,shortname=winnt",
	FSTabFreq: 0,
	FSTabPassNo: 2,
	},
	},
	{
	Size: 1 * GibiByte,
	Type: disk.FilesystemDataGUID,
	UUID: disk.FilesystemDataUUID,
	Payload: &disk.Filesystem{
	Type: "ext4",
	Mountpoint: "/boot",
	Label: "boot",
	FSTabOptions: BootOptions,
	FSTabFreq: 1,
	FSTabPassNo: 2,
	},
	},
	{
	Size: 2 * GibiByte,
	Type: disk.FilesystemDataGUID,
	UUID: disk.RootPartitionUUID,
	Payload: &disk.Filesystem{
	Type: "ext4",
	Label: "root",
	Mountpoint: "/",
	FSTabOptions: RootOptions,
	FSTabFreq: 1,
	FSTabPassNo: 1,
	},
	},
	},
	},
	arch.ARCH_AARCH64.String(): disk.PartitionTable{
	UUID: "0xc1748067",
	Type: "dos",
	Partitions: []disk.Partition{
	{
	Size: 501 * MebiByte,
	Type: "06",
	Bootable: true,
	Payload: &disk.Filesystem{
	Type: "vfat",
	UUID: disk.EFIFilesystemUUID,
	Mountpoint: "/boot/efi",
	Label: "EFI-SYSTEM",
	FSTabOptions: "umask=0077,shortname=winnt",
	FSTabFreq: 0,
	FSTabPassNo: 2,
	},
	},
	{
	Size: 1 * GibiByte,
	Type: "83",
	Payload: &disk.Filesystem{
	Type: "ext4",
	Mountpoint: "/boot",
	Label: "boot",
	FSTabOptions: BootOptions,
	FSTabFreq: 1,
	FSTabPassNo: 2,
	},
	},
	{
	Size: 2569 * MebiByte,
	Type: "83",
	Payload: &disk.Filesystem{
	Type: "ext4",
	Label: "root",
	Mountpoint: "/",
	FSTabOptions: RootOptions,
	FSTabFreq: 1,
	FSTabPassNo: 1,
	},
	},
	},
	},
	}

[yoheiueda]

@cgwalters @mvo5 @achilleas-k

I raised a PR #515 to include the latest images library that includes the fix for the issue reported above.

This PR also updates the setting for golangci-lint CI test to suppress a false-positive lint error.

[yoheiueda]

@cgwalters I created PR #553 to add support for s390x.

@achilleas-k For now, this PR enables QCOW2 only.

[mvo5]

I would like to add some smoke tests to bib for this - is there a quay.io container ref for a bootc enabled s390x container that I can use for testing?

[yoheiueda]

@mvo5

I pushed quay.io/yoheiueda/fedora-bootc:latest. https://quay.io/repository/yoheiueda/fedora-bootc?tab=tags

I encountered several issues to build this image from the latest version of https://gitlab.com/fedora/bootc/base-images, so I manually modified the base image. I'll report the issues later.

[mvo5]

@mvo5

I pushed quay.io/yoheiueda/fedora-bootc:latest. https://quay.io/repository/yoheiueda/fedora-bootc?tab=tags

I encountered several issues to build this image from the latest version of https://gitlab.com/fedora/bootc/base-images, so I manually modified the base image. I'll report the issues later.

Thank you! I updated #566 to point to this container ref. When testing this (or clicking on the link above) I get a " Repository not found " error though, are these images maybe not set to public yet?

[yoheiueda]

@mvo5 Sorry. I made it public.

[cgwalters]

quay.io/fedora/fedora-bootc:41 is built for all 4 primary Fedora architectures since https://pagure.io/fedora-iot/pungi-iot/pull-request/78

[yoheiueda]

@cgwalters Thank you for the info. I tested quay.io/fedora/fedora-bootc:41 on my local environment, and it works fine.

Will the support of the additional architectures eventually come to fedora-40, centos-stream-9, and rhel-9?

BTW, I can't reproduce the issues I reported above any more in my environment, so please forgot it.

[cgwalters]

Will the support of the additional architectures eventually come to fedora-40, centos-stream-9, and rhel-9?

https://gitlab.com/fedora/bootc/tracker/-/issues/15 will track the fedora/c{9,10s} efforts, and since CentOS Stream is RHEL it covers that too implicitly.

[yoheiueda]

@cgwalters Could you please close this issue unless any more change is necessary in this repo to support s390x? I understand that enablement of public container image builds are being tracked by the GitLab issue you mentioned.

[cgwalters]

Thanks for all the work on this everyone!