pkg/osbuild: Skip EFI partition check for non UEFI platforms #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, validateBootupdMounts always ensures that /boot/efi exists. This requirement is not necessary on non-UEFI platforms such as s390x. This patch skips the check for /boot/efi when UEFIVendor is not set. Signed-off-by: Yohei Ueda <[email protected]>
auto-merge was automatically disabled
June 25, 2024 02:29
Head branch was pushed to by a user without write access
yoheiueda
force-pushed
the
skip-efi-part-check
branch
from
5650c07 to
71738a2
Compare
supakeen
approved these changes
Jun 25, 2024
yoheiueda
added a commit
to yoheiueda/bootc-image-builder
that referenced
this pull request
Jul 2, 2024
This patch bumps the version of the images library to v0.69.0 as well as go to v1.21, since the library requires the Go version. This version includes a necessary fix to support partition layouts for non-UEFI platforms. osbuild/images#758 Signed-off-by: Yohei Ueda <[email protected]>
yoheiueda
added a commit
to yoheiueda/bootc-image-builder
that referenced
this pull request
Jul 4, 2024
This patch bumps the version of the images library to v0.69.0 as well as go to v1.21, since the library requires the Go version. This version includes a necessary fix to support partition layouts for non-UEFI platforms. osbuild/images#758 Signed-off-by: Yohei Ueda <[email protected]>
achilleas-k
pushed a commit
to yoheiueda/bootc-image-builder
that referenced
this pull request
Jul 4, 2024
This patch bumps the version of the images library to v0.69.0 as well as go to v1.21, since the library requires the Go version. This version includes a necessary fix to support partition layouts for non-UEFI platforms. osbuild/images#758 Signed-off-by: Yohei Ueda <[email protected]>
github-merge-queue bot
pushed a commit
to osbuild/bootc-image-builder
that referenced
this pull request
Jul 4, 2024
This patch bumps the version of the images library to v0.69.0 as well as go to v1.21, since the library requires the Go version. This version includes a necessary fix to support partition layouts for non-UEFI platforms. osbuild/images#758 Signed-off-by: Yohei Ueda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, validateBootupdMounts always ensures that
/boot/efiexists. This requirement is not necessary on non-UEFI platforms such as s390x.This patch skips the check for
/boot/efiwhen UEFIVendor is not set.This change is required for this issue: osbuild/bootc-image-builder#460