plugin/builder: increase retries for requests to composer #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supakeen
reviewed
Oct 18, 2024
The fedora koji instance often has trouble contacting the composer api, let's just make the retries a lot more generous.
|
Note: codespell was removed here due to it's inability to handle CamelCase and the came case in question is from the external unittest library (which we won't change 😉 ) sidenode: an other option might be to disable checking of function names of external libraries, but also there doesn't seem to be support in codespell for this either |
supakeen
previously approved these changes
Oct 21, 2024
|
The code changes are OK but shenanigans are going on with CI (CodeCov, Schutzbot). |
Koji complains if the `repo` isn't present.
This check is failing on the spelling of the valid function `assertIn` of the unittest library.
This package is no longer shipped.
|
Ok I think I got everything now, f41 didn't work because we're not building/testing f41 in composer yet, and koji-osbuild depends on osbuild-composer-tests. |
croissanne
force-pushed
the
retries
branch
3 times, most recently
from
b01ac2a
to
f512d59
Compare
Drop the package sets, I'm not sure they exist anymore in that form, it breaks depsolving. Also pirnt the journal logs during the test to make it easier to debug failures.
croissanne
changed the title
supakeen
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fedora koji instance often has trouble contacting the composer api, let's just make the retries a lot more generous.