Modest tweaks from reviewing doc #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/data/osdf/install-cache-rpm.md
Outdated
| @@ -19,8 +19,7 @@ Before starting the installation process, consider the following requirements: | |||
| * __Host certificate:__ Required for authentication. See note below. | |||
| * __Network ports:__ The cache service requires the following ports open: | |||
| * Inbound TCP port 8443 for file access via the HTTP(S) and XRoot protocols. | |||
| * (Optional) Inbound TCP port 8444 for access to the web interface for monitoring and configuration; | |||
| if enabled, access to this port should be restricted to the LAN. | |||
| * Inbound TCP port 8444 for access to the web interface for monitoring and configuration. | |||
There was a problem hiding this comment.
This is a security hazard until PelicanPlatform/pelican#1227 is solved.
There was a problem hiding this comment.
@matyasselmeci please make the suggestion to revert, apply it, then go ahead and merge this PR. We can sort out this detail at a future date.
matyasselmeci
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.