This repository has been archived by the owner on Feb 20, 2021. It is now read-only.
Various fixes to web and rest #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need a bit of time to run this and verify this ... |
Due to changes in bnd and other stuff need to hardcode url to pom
…cessarily be enabled. Signed-off-by: David Leangen <[email protected]>
Signed-off-by: David Leangen <[email protected]>
Signed-off-by: David Leangen <[email protected]>
Signed-off-by: David Leangen <[email protected]>
Signed-off-by: David Leangen <[email protected]>
dleangen
force-pushed
the
aggregated-fixes
branch
from
65129fb
to
39bb1fa
Compare
|
Hey @pkriens, Ping! Think you'll have some time one of these days to look into this PR? :-) Cheers, |
|
Its a big commit and no test cases and I am ssssoooooo busy :-(
So you need to have a bit more patience … sorry
Kind regards,
Peter Kriens
… On 3 Aug 2018, at 00:12, David Leangen ***@***.***> wrote:
Hey @pkriens <https://github.com/pkriens>,
Ping! Think you'll have some time one of these days to look into this PR? :-)
Cheers,
=David
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMPLve86WOiqxTlu76_b68YhAMNHQ0_ks5uM3lXgaJpZM4VGoCE>.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @pkriens,
Here is my first PR. These are fixes that I've been wanting to integrate since quite a long time ago.
Let me know if you have any questions. Honestly, it's been so long that the details have fallen out of my memory.
Cheers,
=David