Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024.1: add backport-928288.patch #514

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

2024.1: add backport-928288.patch #514

wants to merge 1 commit into from

Conversation

berendt
Copy link
Member

@berendt berendt commented Dec 4, 2024

@berendt berendt added the zuul Release the dragons, run Zuul CI label Dec 4, 2024
@osfrickler osfrickler added zuul Release the dragons, run Zuul CI and removed zuul Release the dragons, run Zuul CI labels Dec 5, 2024

NB2: this patch assumes that 0.0.0.0/0 snat rules are properly handled
by OVN. Some (e.g. 22.03 and 24.03) OVN versions may have this scenario
broken. See: https://issues.redhat.com/browse/FDP-744 for details.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't seem to find out which versions of OVN would not be broken. Are you sure that this would not affect us?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default is ovn_router_indirect_snat = False which should keep the current behaviour.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the crucial patch is included in OVN versions v24.09.1 and v24.09.0: ovn-org/ovn@40136a2f

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have OVN 24.03 in OSISM 8.0.2. The OVN version will not be changed in the next months.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you rather wait with adding this backport until you can switch to v24.09.x or is it maybe possible to add the backport and let us use the newer version already via images.yml? Or are the images not even existent?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so to me this sounds like adding this backport is useless, then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you rather wait with adding this backport until you can switch to v24.09.x or is it maybe possible to add the backport and let us use the newer version already via images.yml? Or are the images not even existent?

OVN 24.03 is a LTS release of OVN. 24.09 is the latest OVN release. I think it's a bad idea to use a OVN release that's newer than the OpenStack Neutron release you have in use.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay then we could/should probably wait until v24.09.x is usable.

@berendt berendt added the on hold Is on hold label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold Is on hold zuul Release the dragons, run Zuul CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support nested SNAT for ml2/ovn
3 participants