-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2024.1: add backport-928288.patch #514
base: main
Are you sure you want to change the base?
Conversation
https://review.opendev.org/c/openstack/neutron/+/928288 Closes osism/issues#1187 Signed-off-by: Christian Berendt <[email protected]>
|
||
NB2: this patch assumes that 0.0.0.0/0 snat rules are properly handled | ||
by OVN. Some (e.g. 22.03 and 24.03) OVN versions may have this scenario | ||
broken. See: https://issues.redhat.com/browse/FDP-744 for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't seem to find out which versions of OVN would not be broken. Are you sure that this would not affect us?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default is ovn_router_indirect_snat = False
which should keep the current behaviour.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the crucial patch is included in OVN versions v24.09.1 and v24.09.0: ovn-org/ovn@40136a2f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have OVN 24.03 in OSISM 8.0.2. The OVN version will not be changed in the next months.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you rather wait with adding this backport until you can switch to v24.09.x or is it maybe possible to add the backport and let us use the newer version already via images.yml
? Or are the images not even existent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so to me this sounds like adding this backport is useless, then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you rather wait with adding this backport until you can switch to v24.09.x or is it maybe possible to add the backport and let us use the newer version already via
images.yml
? Or are the images not even existent?
OVN 24.03 is a LTS release of OVN. 24.09 is the latest OVN release. I think it's a bad idea to use a OVN release that's newer than the OpenStack Neutron release you have in use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay then we could/should probably wait until v24.09.x is usable.
https://review.opendev.org/c/openstack/neutron/+/928288
Closes osism/issues#1187