Draft: Make use of job variable in upstream role #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gondermann <[email protected]>
gndrmnn
force-pushed
the
add_build_job
branch
from
7109642 to
9306e21
Compare
gndrmnn
commented
Sep 25, 2023
| @@ -4,6 +4,8 @@ | |||
| roles: | |||
| - upload-pypi | |||
| vars: | |||
| python_venv_dir: "$HOME/venv" | |||
| pypi_twine_executable: "{{ python_venv_dir }}/bin/python -m twine" | |||
There was a problem hiding this comment.
This is the critical part. Can the role use the variable defined in the vars section in the same file?!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So i hope this can solve all points specified in #51 but I have absolutely no idea if this works as I intend it to. Is there anyway to test this short of just merging and hoping for the best?