Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OMpy installation issue on Mac with the M1-chip #190

Open
andreashmj opened this issue Oct 19, 2021 · 1 comment · May be fixed by #203
Open

OMpy installation issue on Mac with the M1-chip #190

andreashmj opened this issue Oct 19, 2021 · 1 comment · May be fixed by #203

Comments

@andreashmj
Copy link

andreashmj commented Oct 19, 2021

I have successfully managed to install OMpy on my MacBook with the M1-chip. However, I had problems with some of the compilation flags in setup.py. The consequence was that the command

pip install -e .

failed.

Fix:
The workaround for me has been to remove the flags "march=native" and "mfpmath=sse" in setup.py, which seem to be invalid for Apple M1. Then the pip installation works fine.

@vetlewi
Copy link
Collaborator

vetlewi commented Oct 22, 2021

Hi,

I've made a PR with a fix. In theory the march=native flag shouldn't break any compilation as it tells the compiler only to optimise for the specific CPU of the system. The mfpmath=sse flag is x86 specific. I've changed the setup to ensure that this is disabled for non-x86 platforms.

@andreashmj could you try to install with this: https://github.com/vetlewi/ompy/archive/refs/heads/fix/issue/190/M1-compile-issue.zip?

@vetlewi vetlewi linked a pull request Jan 17, 2023 that will close this issue
@vetlewi vetlewi linked a pull request Jan 18, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants