Fix for setup issue on non-x86 platforms #191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR also adds "support" for GCC on macOS. This is not a normal setup and I'm considering removing it again. I cannot see any good reason to use GCC instead of clang... |
I removed it. Added a note in the FAQ. |
|
Can confirm that it compiles on laptops with M1 processors. Ready for merge. |
The setup.py script used a x86 spesific flags,`-mfpmath=sse`, that would break compilation on other architectures. This flag is now disabled for architectures other than x86.
If macOS we will also check if the default compiler is clang or gcc.
I've updated the setup script to detect check the CC flag for what compiler to use. I've also added a super simple hacky test that removes the `-stdlib=libc++` compile flag. However, this will probably not work unless GCC are also used to compile python since libc++ of clang and libstdc++ are not ABI compatible. There will probably be link issues.
I've added a note about using GCC under macOS in the FAQ section.
Added a note about the fixes added in this PR
I decided that we shouldn't even consider this. Way too much hassel, not any great payout.
vetlewi
force-pushed
the
fix/issue/190/M1-compile-issue
branch
from
feedf3b to
3010995
Compare
|
|
Being fixed in another PR, closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The setup.py script used a x86 spesific flags,
-mfpmath=sse, that would break compilation on other architectures. This flag is now disabled for architectures other than x86. Fixes issue #190.Marked as draft awaiting test on an actual M1 computer.