Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fast tm-db #2009

Closed
wants to merge 2 commits into from
Closed

feat: fast tm-db #2009

wants to merge 2 commits into from

Conversation

faddat
Copy link
Member

@faddat faddat commented Jul 10, 2022

What is the purpose of the change

  • Large performance boost (observational, made syncing evmos archives even... possible instead of impossible, powers notional's rpcs and our osmosis and evmos validators)
    • Synthetic benchmarks don't really show the performance gains.

Brief Changelog

Uses this tm-db branch:

tendermint/tm-db#237

  • supports rocksdb 7.x
  • numerous goleveldb performance enhancements
  • approximate performance parity btw rocks and goleveldb, situationally variable

Testing and Verifying

Better tests are needed upstream here, especially for benchmarking purposes.

tendermint/tm-db#237

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? yes
  • How is the feature or change documented? not applicable

@faddat faddat requested a review from a team July 10, 2022 02:57
@github-actions github-actions bot added the C:docs Improvements or additions to documentation label Jul 10, 2022
@faddat faddat changed the title fast tm-db feat: fast tm-db Jul 10, 2022
@faddat faddat mentioned this pull request Jul 14, 2022
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!

@github-actions github-actions bot added the Stale label Jul 25, 2022
@github-actions github-actions bot closed this Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:docs Improvements or additions to documentation Stale
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant