Host scan support for iOS #85
Conversation
git-elliot
changed the title
| _targetIPEditingController.text, | ||
| int.parse(_singlePortEditingController.text), | ||
| ).then((value) { | ||
| _handleEvent(value); | ||
| _handleOnDone(); | ||
| }); | ||
| } else if (_type == ScanType.top) { | ||
| _streamSubscription = PortScanner.customDiscover( | ||
| _streamSubscription = PortScannerFlutter.customDiscover( |
There was a problem hiding this comment.
Why isn't it called PortScanner there is no need to specify that it is from a different library.
There was a problem hiding this comment.
Although it can be kept same, but then users have to add alias to import statement when using both. To simplify it I'm suffixing Flutter word
There was a problem hiding this comment.
They aren't supposed to import both of the packages, flutter version should extended and replace dart package
And expose same functionality and more outside for the developer
pubspec.yaml
Outdated
| network_tools: ^3.2.1 | ||
| # network_tools: | ||
| # path: ../network_tools/network_tools | ||
| network_tools: ^3.2.2 |
There was a problem hiding this comment.
network_tools_flutter should include network_tools and expose everything that the user needs.
There is no reason users will have to add 2 packages.
There was a problem hiding this comment.
The imported package 'network_tools' isn't a dependency of the importing package.
Try adding a dependency for 'network_tools' in the 'pubspec.yaml' file.dartdepend_on_referenced_packages
There was a problem hiding this comment.
So we need to fix it, if we exposed the functions through network_tools_fluttet the programmers will add only one package
There was a problem hiding this comment.
dart can not expose another package I guess and I can not replicate classes. Show me some example otherwise.
There was a problem hiding this comment.
Create a file like this in network_tools_flutter
https://github.com/osociety/network_tools/blob/dev/lib/network_tools.dart
and point it to this file
No description provided.