Increase Pnpm's fun test coverage a bit #9341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9341 +/- ##
=========================================
Coverage 67.47% 67.47%
Complexity 1200 1200
=========================================
Files 241 241
Lines 8506 8506
Branches 904 904
=========================================
Hits 5739 5739
Misses 2403 2403
Partials 364 364
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fviernau
force-pushed
the
pnpm-test-coverage
branch
from
afc30ba
to
781dca1
Compare
sschuberth
requested changes
Oct 25, 2024
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "npm-project-that-depends-on-babel", | |||
| "version": "1.0.0", | |||
| "lockfileVersion": 2, | |||
| "lockfileVersion": 3, | |||
There was a problem hiding this comment.
For completeness, could you add to the commit message which version of NPM was used to recreate the lockfile? I noticed that the lockfile format version changed, but I guess that's ok as this specific test does not depend on it.
| @@ -0,0 +1,13 @@ | |||
| { | |||
There was a problem hiding this comment.
Commit message:
- "to have more confidence from it in an upcoming refactoring" -> "to have more confidence for an upcoming refactoring"
- 'package.json' should use backticks instead of single quotes
- Just a proposal: "fun test" -> "funTest" or "functional test"
| @@ -41,6 +41,15 @@ class PnpmFunTest : WordSpec({ | |||
| result.toYaml() should matchExpectedResult(expectedResultFile, definitionFile) | |||
| } | |||
|
|
|||
| "resolve dependencies for a project depending on babel correctly" { | |||
Prepare for an upcoming change which intends to add an analog, comparable test case for Pnpm. Note: The lockfile has been updated with Npm version 10.8.3. Signed-off-by: Frank Viernau <[email protected]>
fviernau
force-pushed
the
pnpm-test-coverage
branch
from
781dca1
to
37b08b5
Compare
Increase the test coverage to have more confidence for an upcoming refactoring. Use the same `package.json` as for the analog NPM fun test, for comparison in the hope to get some new insights. Note: The lockfile has been created with Pnpm version 9.9.0 Signed-off-by: Frank Viernau <[email protected]>
fviernau
force-pushed
the
pnpm-test-coverage
branch
from
37b08b5
to
49ee322
Compare
sschuberth
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the babel test analog to the one for NPM, for comparability.
Part of #9261.