Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node: Prepare for a larger Npm refactoring #9385

Merged
merged 6 commits into from
Nov 6, 2024
Merged

node: Prepare for a larger Npm refactoring #9385

merged 6 commits into from
Nov 6, 2024

Commits on Nov 6, 2024

  1. refactor(node)!: Invert the inheritance between Yarn and Npm 

    Prepare for re-writing large parts of `Npm` to no more rely on the file
hierarchy of `node_modules` when constructing the dependency tree.

While the same is planned for `Yarn` too, this change is just a
refactoring step which allows to do `Npm` first.

Signed-off-by: Frank Viernau <[email protected]>
    @fviernau
    fviernau committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    d9bcf4a View commit details
    Browse the repository at this point in the history

  2. refactor(yarn)!: Make loadWorkspaceSubmodules() private 

    As of the recent refactoring of `Pnpm`, the is no more override of this
function in ORT. So, make the function private.

Signed-off-by: Frank Viernau <[email protected]>
    @fviernau
    fviernau committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    d02a0f4 View commit details
    Browse the repository at this point in the history

  3. refactor(node): Move two model mapping functions to NpmSupport 

    The functions `parseProject()` and `parsePackage()` are used by mutliple
package managers. Move them to `NpmSupport` which contains common code
to account for that.

Signed-off-by: Frank Viernau <[email protected]>
    @fviernau
    fviernau committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    4dd7283 View commit details
    Browse the repository at this point in the history

  4. refactor(node)!: Move Yarn into its own dedicated directory 

    Align with `pnpm` and `yarn2`.

Signed-off-by: Frank Viernau <[email protected]>
    @fviernau
    fviernau committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    385b55f View commit details
    Browse the repository at this point in the history

  5. refactor(node)!: Also move Npm into its own dedicated directory 

    Establish consistency and prepare for an upcoming refactoring of `Npm`
which will add further classes under the `npm` directory.

Signed-off-by: Frank Viernau <[email protected]>
    @fviernau
    fviernau committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    0a85e82 View commit details
    Browse the repository at this point in the history

  6. refactor(node): Remove a dependency on Npm 

    Use an own logger instead of the one from `Npm`.

Signed-off-by: Frank Viernau <[email protected]>
    @fviernau
    fviernau committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    92f0710 View commit details
    Browse the repository at this point in the history