-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix AOSD2 export #9452
Fix AOSD2 export #9452
Conversation
Thanks for these changes @GothHans. A while ago I receiced the specs for AOSD 2.1 from Audi support, wheres ORT currently is implemented against spec version 2.0. So far, I didn't have the change to look into 2.0 vs 2.1 changes, but I'll do so in the context of your changes. Do you happen to know whether your upload is expected to be in AOSD 2.0 or 2.1 format? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9452 +/- ##
============================================
- Coverage 67.97% 67.93% -0.04%
+ Complexity 1291 1289 -2
============================================
Files 249 249
Lines 8792 8792
Branches 913 913
============================================
- Hits 5976 5973 -3
- Misses 2431 2433 +2
- Partials 385 386 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Nevermind, looks like AOSD 2.1 is in preview state still, so it should be AOSD 2.0. |
@sschuberth Currently the change to 2.1 is still ongoing. For new projects they suggest to use 2.1, but there is a converter that can convert files form 2.0 to 2.1 format (files can be converted on request, but the converter is not availabe for external use yet). The structure of the 2.1 is significantly different from the 2.0 format. (They claim that 2.1 is the less complex format.) |
True, that's what I've figured from looking at the 2.1 schema.
Let's first try to get 2.0 fully working, and add 2.1 support once it's finalized. @GothHans there are a few issues with your PR that cause CI checks to fail. However, it's probably easier if I simply do these changes for you as you've luckily "Allow edits from maintainers" enabled. |
Signed-off-by: Sebastian Schuberth <[email protected]>
Signed-off-by: Hans Goth <[email protected]> Signed-off-by: Sebastian Schuberth <[email protected]>
4c4e52c
to
7d1bdde
Compare
Signed-off-by: Hans Goth <[email protected]> Signed-off-by: Sebastian Schuberth <[email protected]>
7d1bdde
to
b572542
Compare
Merging despite the unrelated |
Thanks for you contribution @GothHans! It will be included in the ORT release for this Thursday. |
When trying to upload the AOSD 2.0 file generated with ORT to the AOSD platform we encountered some problems.
After always creating a default "part", including empty fields (that where marked as optional but seem to be necessary) and removing hash algorithms other than SHA256 the file can now be uploaded to the Audi AOSD platform.