Fix JSON schema for FileStorage #9456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcel Bochtler <[email protected]>
The `FileStorageProvider` requires exactly one storage provider configured [1]. [1]: https://github.com/oss-review-toolkit/ort/blob/d7a516442278cf28ad412c98baab847a7e7510ce/model/src/main/kotlin/config/FileStorageConfiguration.kt#L52-L54 Resolves oss-review-toolkit#7283. Signed-off-by: Marcel Bochtler <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9456 +/- ##
=========================================
Coverage 67.93% 67.93%
Complexity 1289 1289
=========================================
Files 249 249
Lines 8792 8792
Branches 913 913
=========================================
Hits 5973 5973
Misses 2433 2433
Partials 386 386
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
sschuberth
approved these changes
Nov 19, 2024
|
Merging despite the unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.