Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(model): Add a comment about the algorithm in traverse() #9483

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

sschuberth
Copy link
Member

@oheger-bosch am I correctly describing the rationale here why traversing is not stopped after finding the first match for a node?

@sschuberth sschuberth requested a review from a team as a code owner November 21, 2024 15:11
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.93%. Comparing base (0ff17e7) to head (132e35b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #9483   +/-   ##
=========================================
  Coverage     67.93%   67.93%           
+ Complexity     1291     1289    -2     
=========================================
  Files           249      249           
  Lines          8792     8792           
  Branches        913      913           
=========================================
  Hits           5973     5973           
  Misses         2433     2433           
  Partials        386      386           
Flag Coverage Δ
funTest-docker 64.82% <ø> (ø)
funTest-non-docker 33.34% <ø> (-0.14%) ⬇️
test 35.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@oheger-bosch oheger-bosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks good to me.

@sschuberth sschuberth enabled auto-merge (rebase) November 21, 2024 15:43
@sschuberth sschuberth merged commit 9103ac2 into main Nov 21, 2024
23 checks passed
@sschuberth sschuberth deleted the traverse-comment branch November 21, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants